-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emv fixes #702
Emv fixes #702
Conversation
* Could break communication with another cards
This reverts commit ab609bc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to load saved dump
22c62c8
to
a9de06d
Compare
FYI, im seeing empty transaction history on my mastercard with this PR's changes, shows fine without. not sure where exactly the issue would be, dont see any changes related to transactions at a first sweep through the diff... either way great work, looking forward to this :) |
Co-authored-by: Nikita Vostokov <1042932+wosk@users.noreply.github.com>
i was able to get transaction history to work again for my mastercard by reverting the working (gets transaction history) (dev branch):
broken (no transactions info) (pr head):
|
@Willy-JL Thank you! the problem was that the attempt to brute force files 2-3 was before reading transactions. Some cards, after attempting to read a record that does not exist on them, refuse to respond to subsequent requests. this seems to be done for security reasons |
@wosk thank you for the productive collaboration! |
can confirm the transactions work again, thanks! |
What's new
Verification
Checklist (For Reviewer)